Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker login additional configuration options for docker authentication #51531

Open
c4t3l opened this issue Feb 6, 2019 · 8 comments
Open

Docker login additional configuration options for docker authentication #51531

c4t3l opened this issue Feb 6, 2019 · 8 comments
Labels
Feature
Milestone

Comments

@c4t3l
Copy link

@c4t3l c4t3l commented Feb 6, 2019

registry_auth = __pillar__.get('docker-registries', {})

In reference to the above, would it be possible to make this function use master/minion config files as well as pillar data? I have used the "trifecta" of configuration options in other modules, but my external pillar setup does not easily support this particular configuration.

I am running salt version 2018.3.2 on Centos 7. My external pillar system is etcd.

@c4t3l
Copy link
Author

@c4t3l c4t3l commented Feb 7, 2019

profile = salt'config.option'

  • from Cody

@dwoz
Copy link
Contributor

@dwoz dwoz commented Feb 8, 2019

@terminalmage What are your thoughts on this?

@dwoz dwoz added the Feature label Feb 8, 2019
@dwoz dwoz added this to the Approved milestone Feb 8, 2019
@c4t3l
Copy link
Author

@c4t3l c4t3l commented Feb 8, 2019

I would like to submit the PR for this. I will have time to do it over the weekend.

c4t3l pushed a commit to c4t3l/salt that referenced this issue Feb 9, 2019
…nsulting Pillar.

Data structure is required to only pass `docker-registries` key.

Corrected typo in config.option call.

Fixes saltstack#51531.
c4t3l pushed a commit to c4t3l/salt that referenced this issue Feb 9, 2019
…nsulting Pillar.

Data structure is required to only pass `docker-registries` key.

Corrected typo in config.option call.

Corrected grammar in docstring.

Fixes saltstack#51531.
@terminalmage
Copy link
Collaborator

@terminalmage terminalmage commented Feb 12, 2019

See my comments here.

@terminalmage
Copy link
Collaborator

@terminalmage terminalmage commented Feb 15, 2019

Alternate implementation here: #51677

@stale
Copy link

@stale stale bot commented Jan 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 9, 2020
@terminalmage
Copy link
Collaborator

@terminalmage terminalmage commented Jan 9, 2020

This was fixed 11 months ago. Please close this rather than letting it be closed as "stale".

@stale
Copy link

@stale stale bot commented Jan 9, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature
Projects
None yet
Development

No branches or pull requests

3 participants