Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker login additional configuration options for docker authentication #51531

Open
c4t3l opened this issue Feb 6, 2019 · 8 comments
Open

Docker login additional configuration options for docker authentication #51531

c4t3l opened this issue Feb 6, 2019 · 8 comments
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Milestone
Approved

Comments

@c4t3l
Copy link

c4t3l commented Feb 6, 2019

salt/salt/modules/dockermod.py

Line 1393 in 927adb3

registry_auth = __pillar__.get('docker-registries', {})

In reference to the above, would it be possible to make this function use master/minion config files as well as pillar data? I have used the "trifecta" of configuration options in other modules, but my external pillar setup does not easily support this particular configuration.

I am running salt version 2018.3.2 on Centos 7. My external pillar system is etcd.
@c4t3l
Copy link
Author

c4t3l commented Feb 7, 2019

profile = salt'config.option'

  • from Cody

@dwoz
Copy link
Contributor

dwoz commented Feb 8, 2019

@terminalmage What are your thoughts on this?

@dwoz dwoz added the Feature new functionality including changes to functionality and code refactors, etc. label Feb 8, 2019
@dwoz dwoz added this to the Approved milestone Feb 8, 2019
@c4t3l
Copy link
Author

c4t3l commented Feb 8, 2019

I would like to submit the PR for this. I will have time to do it over the weekend.

c4t3l added a commit to c4t3l/salt that referenced this issue Feb 9, 2019
@c4t3l
Changed docker.login function to use config.option instead of only co…
8311691 
…nsulting Pillar.

Data structure is required to only pass `docker-registries` key.

Corrected typo in config.option call.

Fixes saltstack#51531.
c4t3l added a commit to c4t3l/salt that referenced this issue Feb 9, 2019
@c4t3l
Changed docker.login function to use config.option instead of only co…
fc3c48a 
…nsulting Pillar.

Data structure is required to only pass `docker-registries` key.

Corrected typo in config.option call.

Corrected grammar in docstring.

Fixes saltstack#51531.
@c4t3l c4t3l mentioned this issue Feb 9, 2019
Closed
@terminalmage
Copy link
Contributor

See my comments here.

@terminalmage terminalmage mentioned this issue Feb 15, 2019
Merged
@terminalmage
Copy link
Contributor

Alternate implementation here: #51677

@stale
Copy link

stale bot commented Jan 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 9, 2020
@terminalmage
Copy link
Contributor

This was fixed 11 months ago. Please close this rather than letting it be closed as "stale".

@stale
Copy link

stale bot commented Jan 9, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
3 participants
@terminalmage @dwoz @c4t3l