Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python 3 http server command #51748

Closed
alan-cugler opened this issue Feb 21, 2019 · 5 comments

Comments

@alan-cugler
Copy link
Contributor

commented Feb 21, 2019

Question

I am about to make a PR for adding the python 3 command python3 -m http.server to the BUILDING THE DOCS BASH commands in step 4. My question is which style is more preferred?

Exhibit A:

screenshot001

Exhibit B:

screenshot002

Exhibit C:

screenshot003

@garethgreenaway

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

@alan-cugler Thanks for this report and the upcoming PR, my preference is exhibit A. @saltstack/team-core Thoughts?

@thatch45

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

I would say exhibit b, python3 should always get top billing

@garethgreenaway

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

@thatch45 What about the layout, eg. different boxes, of Exhibit A but top billing of Python 3 as in Exhibit B?

@thatch45

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Yes, I will go with you there, Exhibit A with python3 top billing would be the best

@alan-cugler

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Alright, I'll put in a PR later.

alan-cugler added a commit to terminal-labs/salt that referenced this issue Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.