Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ping with version in docx #52277

Closed
alan-cugler opened this issue Mar 21, 2019 · 3 comments

Comments

@alan-cugler
Copy link
Contributor

commented Mar 21, 2019

Suggested docx change

replace:
salt "*" test.ping
with:
salt "*" test.version

Reasoning

Any experienced salt user I talk to recommends using version over ping because it completes the same task and gives awareness of your salt versioning and a potential chance to catch a versioning mistake.

On this docx page and any others I can find.

@alan-cugler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

If its already recommended by salt savvy peoples, then we should teach it from the beginning when people are first learning salt.

@Ch3LL

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

that is a fair suggestion. should be a easy change if you want to give it a go

@Ch3LL Ch3LL added the Documentation label Mar 22, 2019
@Ch3LL Ch3LL added this to the Approved milestone Mar 22, 2019
@alan-cugler

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

Yeah, I'll replace and PR. Thanks @Ch3LL

alan-cugler added a commit to terminal-labs/salt that referenced this issue Mar 25, 2019
Result of issue saltstack#52277

Any where `test.ping` still exists in the docs was left
because of the context in those docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.