Compound targeting by nodegroup broken in 2019.2.0 #52678
Description of Issue/Question
Compound targeting by nodegroup broken in 2019.2.0. Please see details below.
Steps to Reproduce Issue
The text was updated successfully, but these errors were encountered:
The following is logged to /var/log/salt/minion:
I can confirm this is a bug. I've used a group
Master log for command
So in the second case master sends the original target definition not expanding the nodegroup definition. Since minion knows nothing about nodegroups it can't match itself against the target.
Actually took a quick look at my original changeset it is possible that the shallow copy I introduced removed some action at a distance of “expanding” node groups in tgt. I can’t remember if that happens explicitly elsewhere in the codebase, I’ll try to take a peek tomorrow.
I don't think this ever worked, I tried a checkout of v2017.7.2 (pre my change) and the behavior is the same. I think what needs to happen is:
Currently the documentation says
It would be great if the documentation could either be fixed or the compound matcher fix be backported to 2019.2.* (which we'd really prefer!).