Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit.utils.test_args.ArgsTestCase.test_argspec_report failing #52836

Closed
Ch3LL opened this issue May 3, 2019 · 2 comments

Comments

@Ch3LL
Copy link
Contributor

commented May 3, 2019

Description of Issue/Question

Error Message

{'tes[29 chars]ts': (None,), 'varargs': None, 'kwargs': None,[32 chars]1']}} != {'tes[29 chars]ts': None, 'varargs': True, 'kwargs': True, 'args': None}} - {'test_module.test_spec': {'args': ['arg1', 'arg2', 'kwarg1'], + {'test_module.test_spec': {'args': None, -                            'defaults': (None,), ?                                        -     --  +                            'defaults': None, -                            'kwargs': None, ?                                      ^^^  +                            'kwargs': True, ?                                      ^^^  -                            'varargs': None}} ?                                       ^^^  +                            'varargs': True}} ?                                       ^^^ 

Stacktrace

Traceback (most recent call last):
  File "/tmp/kitchen/testing/tests/unit/utils/test_args.py", line 133, in test_argspec_report
    {'kwargs': True, 'args': None, 'defaults': None, 'varargs': True}})
AssertionError: {'tes[29 chars]ts': (None,), 'varargs': None, 'kwargs': None,[32 chars]1']}} != {'tes[29 chars]ts': None, 'varargs': True, 'kwargs': True, 'args': None}}
- {'test_module.test_spec': {'args': ['arg1', 'arg2', 'kwarg1'],
+ {'test_module.test_spec': {'args': None,
-                            'defaults': (None,),
?                                        -     --

+                            'defaults': None,
-                            'kwargs': None,
?                                      ^^^

+                            'kwargs': True,
?                                      ^^^

-                            'varargs': None}}
?                                       ^^^

+                            'varargs': True}}
?                                       ^^^

https://jenkinsci.saltstack.com/job/2019.2.1/view/Crypto/job/salt-ubuntu-1604-py3-pycryptodomex/11/testReport/junit/unit.utils.test_args/ArgsTestCase/test_argspec_report/

@waynew

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

Also failing on develop

2019.2.1 failed ch3ll-zmq-filter-salt-centos-7-py3, salt-centos-7-py3, salt-centos-7-py3-m2crypto, salt-centos-7-py3-pycryptodomex, salt-debian-8-py3, salt-debian-9-py3, salt-fedora-28-py3, salt-fedora-29-py3, salt-opensuse-15-py3, salt-opensuse-42-py3, salt-ubuntu-1604-py3, salt-ubuntu-1604-py3-transport, salt-ubuntu-1804-py3
develop failed salt-debian-8-py3, salt-debian-9-py3, salt-fedora-29-py3, salt-opensuse-42-py3, salt-ubuntu-1604-py3, salt-ubuntu-1604-py3-m2crypto, salt-ubuntu-1604-py3-pycryptodomex, salt-ubuntu-1804-py3, salt-windows-2016-py3, salt-windows-2019-py3

{'tes[29 chars]ts': (None,), 'args': ['arg1', 'arg2', 'kwarg1[32 chars]one}} != {'tes[29 chars]ts': None, 'kwargs': True, 'varargs': True, 'args': None}} - {'test_module.test_spec': {'args': ['arg1', 'arg2', 'kwarg1'], + {'test_module.test_spec': {'args': None, - 'defaults': (None,), ? - -- + 'defaults': None, - 'kwargs': None, ? ^^^ + 'kwargs': True, ? ^^^ - 'varargs': None}} ? ^^^ + 'varargs': True}} ? ^^^


Traceback (most recent call last):
  File "c:\users\admini~1\appdata\local\temp\kitchen\testing\tests\unit\utils\test_args.py", line 133, in test_argspec_report
    {'kwargs': True, 'args': None, 'defaults': None, 'varargs': True}})
AssertionError: {'tes[29 chars]ts': (None,), 'args': ['arg1', 'arg2', 'kwarg1[32 chars]one}} != {'tes[29 chars]ts': None, 'kwargs': True, 'varargs': True, 'args': None}}
- {'test_module.test_spec': {'args': ['arg1', 'arg2', 'kwarg1'],
+ {'test_module.test_spec': {'args': None,
-                            'defaults': (None,),
?                                        -     --

+                            'defaults': None,
-                            'kwargs': None,
?                                      ^^^

+                            'kwargs': True,
?                                      ^^^

-                            'varargs': None}}
?                                       ^^^

+                            'varargs': True}}
?                                       ^^^

		
@waynew waynew added the develop label May 7, 2019
@garethgreenaway

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Will get fixed on develop during the next merge forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.