Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration.states.test_pkg failing on amazon 1 py2 #53274

Closed
Ch3LL opened this issue May 28, 2019 · 4 comments

Comments

@Ch3LL
Copy link
Contributor

commented May 28, 2019

The tests:

integration.states.test_pkg.PkgTest.test_pkg_009_latest_with_epoch
integration.states.test_pkg.PkgTest.test_pkg_010_latest_with_epoch_and_info_installed

are failing on amazon 1 python 2
https://jenkinsci.saltstack.com/job/2019.2.1/job/salt-amazon-1-py2/lastFailedBuild/

@dmurphy18

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Amazon Linux 1 does not have bash-completion as a package

[root@ip-10-200-45-57 ec2-user]# yum list | grep bash
bash.x86_64 4.2.46-28.37.amzn1 installed
bash-doc.x86_64 4.2.46-28.37.amzn1 amzn-main

Test is expecting bash-completion to exist on Amazon Linux 1 when it does not

19:46:02 -----------------------------------------------------------------------------------------------------------------------
19:46:02 -------- Failed Tests -----------------------------------------------------------------------------------------------
19:46:02 -> integration.states.test_pkg.PkgTest.test_pkg_009_latest_with_epoch ..............................................
19:46:02 Traceback (most recent call last):
19:46:02 File "/tmp/kitchen/testing/tests/support/helpers.py", line 212, in wrap
19:46:02 raise exc
19:46:02 AssertionError: False is not True. Salt Comment:
19:46:02 Error occurred installing package(s). Additional info follows:
19:46:02
19:46:02 errors:
19:46:02 - Loaded plugins: priorities, update-motd, upgrade-helper
19:46:02 No package bash-completion available.
19:46:02 Error: Nothing to do
19:46:02 **..........................
**

@dmurphy18

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Adjusted tests, #53323

@dmurphy18

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Updated test after review suggestion to leverage bash-doc instead of bash-completion on Amazon Linux 1

dmurphy18 pushed a commit to dmurphy18/salt that referenced this issue May 31, 2019
Ch3LL added a commit that referenced this issue Jun 6, 2019
Fix for issue #53274, test on Amazon Linux 1
Ch3LL added a commit to Ch3LL/salt that referenced this issue Jun 11, 2019
@KChandrashekhar

This comment has been minimized.

Copy link

commented Jul 2, 2019

Ok, closing this as not seeing this failure anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.