Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
2019.2.1: Breaks Minion-Master Communication #54762
Description of Issue
After our minions were upgraded from 2019.2.0 to 2019.2.1, the communication (IPv6 only) with the master (either 2019.2.0 or 2019.2.1) is broken.
Via tcpdump communication - but with length "0" - is observable.
IPv6-only communication, no special configuration.
Steps to Reproduce Issue
After minion is started:
With downgrade to 2019.2.0 of the minion everything works fine.
Salt: 2019.2.1 Dependency Versions: cffi: 1.12.3 cherrypy: Not Installed dateutil: 2.5.3 docker-py: Not Installed gitdb: 2.0.3 gitpython: 2.1.7 ioflo: Not Installed Jinja2: 2.9.4 libgit2: Not Installed libnacl: Not Installed M2Crypto: Not Installed Mako: Not Installed msgpack-pure: Not Installed msgpack-python: 0.4.8 mysql-python: Not Installed pycparser: 2.19 pycrypto: 2.6.1 pycryptodome: Not Installed pygit2: Not Installed Python: 3.5.3 (default, Sep 27 2018, 17:25:39) python-gnupg: Not Installed PyYAML: 3.12 PyZMQ: 16.0.2 RAET: Not Installed smmap: 2.0.3 timelib: Not Installed Tornado: 4.4.3 ZMQ: 4.2.1 System Versions: dist: debian 9.11 locale: UTF-8 machine: x86_64 release: 4.19.0-0.bpo.5-amd64 system: Linux version: debian 9.11
This is affecting our systems as well. We have a hybrid
I suspect an issue in file:
Or the method is not called at all ...
Since the connect string on old minions looks like this:
And on new minions like this:
So the brackets are missing which leads to a none connectable address.
Went to ansible for a quick fix. Inventory came from
Adapt as needed.
- name: salt_disable_ipv6 hosts: salt become: yes become_method: sudo handlers: - name: restart salt-minion service: name: salt-minion state: restarted tasks: - name: "Remove /etc/salt/minion.d/ipv6.conf" file: path: /etc/salt/minion.d/ipv6.conf state: absent notify: restart salt-minion
With #54784 applied, either over the release version of 2019.2.1, or just using the head of branch 2019.2.1, errors still triggered as below.
Thanks for that stack trace!
The above functions have a side effect of updating
We'll need to do make sure we're consistent in doing the conversion, and then we can assume we're dealing with URI-formatted ips everywhere.