Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not deprecate old syntax in module.run state #55551

Closed
2 tasks
Ch3LL opened this issue Dec 6, 2019 · 1 comment
Closed
2 tasks

Do not deprecate old syntax in module.run state #55551

Ch3LL opened this issue Dec 6, 2019 · 1 comment
Labels
Documentation Duplicate
Milestone

Comments

@Ch3LL
Copy link
Contributor

Ch3LL commented Dec 6, 2019

Description of Issue

In this PR #39891 new syntax was introduced to the module.run state.

Here is an example of before/after:

    # Before
    run_something:
      module.run:
        - name: mymodule.something
        - m_name: 'some name'
        - kwargs: {
          first_arg: 'one',
          second_arg: 'two',
          do_stuff: 'True'
        }
    # After
    run_something:
      module.run:
        mymodule.something:
          - name: some name
          - first_arg: one
          - second_arg: two
          - do_stuff: True

In order to use the new syntax you would need to add a config option:

    use_superseded:
      - module.run

Currently this new syntax was marked to deprecate the old syntax in the Sodium release https://github.com/saltstack/salt/blob/v2019.2.2/salt/states/module.py#L221

This ticket is to track the work to ensure this old syntax never gets deprecated. There are too many people that use the old syntax and it works perfectly fine and we do not want to rip out this behavior.

This ticket should include:

  • removing the deprecation warning
  • updating any docs around the module.run state clarifying that there is two ways of specifying your module.run state instead of messaging around the old syntax eventually being removed.
@waynew waynew added this to Needs triage in [Test] Triage Dec 9, 2019
@frogunder frogunder removed their assignment Dec 19, 2019
@frogunder frogunder added this to the Approved milestone Dec 19, 2019
@frogunder frogunder added Documentation team-core labels Dec 19, 2019
@Ch3LL
Copy link
Contributor Author

Ch3LL commented Dec 21, 2019

duplicate of #53504

@Ch3LL Ch3LL closed this as completed Dec 21, 2019
[Test] Triage automation moved this from Needs triage to Closed Dec 21, 2019
@Ch3LL Ch3LL added the Duplicate label Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Duplicate
Projects
No open projects
[Test] Triage
  
Closed
Development

No branches or pull requests

3 participants