Skip to content

Do not deprecate old syntax in module.run state #55551

Description

@Ch3LL

Description of Issue

In this PR #39891 new syntax was introduced to the module.run state.

Here is an example of before/after:

    # Before
    run_something:
      module.run:
        - name: mymodule.something
        - m_name: 'some name'
        - kwargs: {
          first_arg: 'one',
          second_arg: 'two',
          do_stuff: 'True'
        }
    # After
    run_something:
      module.run:
        mymodule.something:
          - name: some name
          - first_arg: one
          - second_arg: two
          - do_stuff: True

In order to use the new syntax you would need to add a config option:

    use_superseded:
      - module.run

Currently this new syntax was marked to deprecate the old syntax in the Sodium release https://github.com/saltstack/salt/blob/v2019.2.2/salt/states/module.py#L221

This ticket is to track the work to ensure this old syntax never gets deprecated. There are too many people that use the old syntax and it works perfectly fine and we do not want to rip out this behavior.

This ticket should include:

  • removing the deprecation warning
  • updating any docs around the module.run state clarifying that there is two ways of specifying your module.run state instead of messaging around the old syntax eventually being removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    DuplicateDuplicate of another issue or PR - will be closeddocumentationRelates to Salt documentation

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions