Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update version.py to work with new release version (3000) #55896

Closed
frogunder opened this issue Jan 16, 2020 · 3 comments · Fixed by #55942
Closed

Need to update version.py to work with new release version (3000) #55896

frogunder opened this issue Jan 16, 2020 · 3 comments · Fixed by #55942

Comments

@frogunder
Copy link
Contributor

@frogunder frogunder commented Jan 16, 2020

Description of Issue

When changing in salt/version.py Neon to version 3000, the doc tests fail.

Change in version.py:

        'Oxygen'        : (2018, 3),
        'Fluorine'      : (2019, 2),
        'Neon'          : (3000),
        'Sodium'        : (MAX_SIZE - 98, 0),

Get this error in the doc build:

15:27:37  Configuration error:
15:27:37  There is a programmable error in your configuration file:
15:27:37  
15:27:37  Traceback (most recent call last):
15:27:37    File "/var/jenkins/workspace/pr-docs_PR-55875/.nox/docs-html-compress-true/lib/python3.6/site-packages/sphinx/config.py", line 361, in eval_config_file
15:27:37      execfile_(filename, namespace)
15:27:37    File "/var/jenkins/workspace/pr-docs_PR-55875/.nox/docs-html-compress-true/lib/python3.6/site-packages/sphinx/util/pycompat.py", line 86, in execfile_
15:27:37      exec(code, _globals)
15:27:37    File "/var/jenkins/workspace/pr-docs_PR-55875/doc/conf.py", line 239, in <module>
15:27:37      import salt.version
15:27:37    File "/var/jenkins/workspace/pr-docs_PR-55875/salt/version.py", line 60, in <module>
15:27:37      class SaltStackVersion(object):
15:27:37    File "/var/jenkins/workspace/pr-docs_PR-55875/salt/version.py", line 215, in SaltStackVersion
15:27:37      RMATCH = dict((v[:2], k) for (k, v) in iter(NAMES.items()))
15:27:37    File "/var/jenkins/workspace/pr-docs_PR-55875/salt/version.py", line 215, in <genexpr>
15:27:37      RMATCH = dict((v[:2], k) for (k, v) in iter(
@frogunder

This comment has been minimized.

Copy link
Contributor Author

@frogunder frogunder commented Jan 17, 2020

Its related to this #55875

@dmurphy18

This comment has been minimized.

Copy link
Contributor

@dmurphy18 dmurphy18 commented Jan 17, 2020

it is also related to #55892

@waynew

This comment has been minimized.

Copy link
Contributor

@waynew waynew commented Jan 17, 2020

Should it not be (3000,0)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Neon
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants
You can’t perform that action at this time.