[BUG] [v3000] [vRC1 Sodium] [v3001] slsutil.renderer when called through salt-call not exiting after run

[whytewolf]

Description
Running salt-call slsutil.renderer is causing a freeze after the output.

Setup
install salt and render a file with saltutil.renderer salt-call slsutil.renderer watch it stick and have to hit ctrl+c to get a prompt back.

Steps to Reproduce the behavior
salt-call slsutil.renderer salt://test/init.sls file doesn't need to exist.

Expected behavior
salt-call exists after modules return.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions Report

salt-call test.versions

local:
    Salt Version:
               Salt: 3001rc1

    Dependency Versions:
               cffi: Not Installed
           cherrypy: 8.9.1
           dateutil: 2.7.3
          docker-py: Not Installed
              gitdb: 2.0.6
          gitpython: 3.0.7
             Jinja2: 2.10.1
            libgit2: 0.28.3
           M2Crypto: Not Installed
               Mako: Not Installed
       msgpack-pure: Not Installed
     msgpack-python: 0.6.2
       mysql-python: Not Installed
          pycparser: Not Installed
           pycrypto: 2.6.1
       pycryptodome: 3.6.1
             pygit2: 1.0.3
             Python: 3.8.2 (default, Apr 27 2020, 15:53:34)
       python-gnupg: 0.4.5
             PyYAML: 5.3.1
              PyZMQ: 18.1.1
              smmap: 2.0.5
            timelib: Not Installed
            Tornado: 4.5.3
                ZMQ: 4.3.2

    System Versions:
               dist: ubuntu 20.04 focal
             locale: utf-8
            machine: x86_64
            release: 5.4.0-29-generic
             system: Linux
            version: Ubuntu 20.04 focal

[b-a-t]

As we are heavily using slsutil.renderer for syntax validation in the Git hooks for sls that looks pretty bad to me.

[frogunder]

@whytewolf Thanks for reporting this issue.

[OrangeDog]

Sounds like the same thing as #57456

[sagetherage]

changing the severity to high - subjective definitions but my gut tells me this is high vs medium

[piterpunk]

I guess this bug was silently fixed by other changes.

I did tried to reproduce using 2020-06-09 git with an non-existent file:

root@marvin:~# salt-call slsutil.renderer salt://test/init.sls
[ERROR   ] Unable to fetch file salt://test/init.sls from saltenv base.
[ERROR   ] Template was specified incorrectly: False
local:
    ----------

And with an existent one:

root@marvin:~# salt-call slsutil.renderer salt://lvmtst/init.sls
local:
    ----------
    lv_opt:
        ----------
        lvm.lv_present:
            |_
              ----------
              name:
                  lala
            |_
              ----------
              vgname:
                  marvinvg01
            |_
              ----------
              size:
                  512

salt --versions-report

Salt Version:
           Salt: 3001
 
Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: Not Installed
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
         Jinja2: 2.11.2
        libgit2: Not Installed
       M2Crypto: 0.35.2
           Mako: 1.1.3
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: 3.9.7
         pygit2: Not Installed
         Python: 3.8.3 (default, May 15 2020, 05:51:00)
   python-gnupg: Not Installed
         PyYAML: 3.13
          PyZMQ: 18.1.1
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.5.3
            ZMQ: 4.3.2
 
System Versions:
           dist: slackware 14.2 current
         locale: utf-8
        machine: i686
        release: 5.4.45
         system: Linux
        version: Slackware 14.2 current

[OrangeDog]

@piterpunk or it's not reproducible on Slackware. Do you see the problem using the RC instead?