Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "superseded" means the old thing #57919

Open
OrangeDog opened this issue Jul 13, 2020 · 4 comments
Open

[BUG] "superseded" means the old thing #57919

OrangeDog opened this issue Jul 13, 2020 · 4 comments
Labels
Bug severity-medium
Milestone

Comments

@OrangeDog
Copy link
Collaborator

@OrangeDog OrangeDog commented Jul 13, 2020

Therefore the config option use_superseded has the opposite meaning to what it does.

v. To be discarded or discontinued as useless or obsolete; to be replaced by something else.
adj. No longer in use.

@OrangeDog OrangeDog added the Bug label Jul 13, 2020
@OrangeDog
Copy link
Collaborator Author

@OrangeDog OrangeDog commented Jul 13, 2020

The only thing that uses it is the module.run state.

As the styles are mutually-exclusive, the state could be written to support both (and warn on the old one), without any need for a config option. The misnamed option can then simply be deleted.

@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Jul 15, 2020

I just learned that @meaksh implemented a compatibility layer that can automatically handle the differences between the module.run syntaxes: https://github.com/uyuni-project/uyuni/blob/master/susemanager-utils/susemanager-sls/src/states/mgrcompat.py

@OrangeDog
Copy link
Collaborator Author

@OrangeDog OrangeDog commented Jul 15, 2020

That's a slightly different approach - it detects what it "should" be, and converts the input to be that.
I meant something that detects which style it is, and runs it (which could be by always converting to the new format).

Or, given it's been deprecated for a while, the old style could simply be dropped, and the config option along with it.

@sagetherage sagetherage added the severity-medium label Jul 16, 2020
@sagetherage sagetherage added this to the Approved milestone Jul 16, 2020
@sagetherage sagetherage modified the milestones: Approved, Aluminium Jul 29, 2020
@sagetherage sagetherage added the Aluminium label Jul 29, 2020
@sagetherage sagetherage removed Aluminium status-in-prog labels Mar 5, 2021
@sagetherage sagetherage modified the milestones: Aluminium, Approved Mar 5, 2021
@waynew
Copy link
Contributor

@waynew waynew commented Oct 19, 2021

I support removing the option (the other issues discussing the module.run disambiguity are 👍 ), since 1) it's mis-named, and 2) it's not useful.

That should be done as part of the module.run silliness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug severity-medium
Projects
None yet
Development

No branches or pull requests

5 participants