New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Salt Deltaproxy NAPALM Issues - PR #60090 #60177
Comments
@ggiesen A couple things to look at here but can you update your proxy configurations and enable multiprocessing? Thanks! |
Way ahead of you. Made no difference. FYI per docs here https://docs.saltproject.io/en/latest/ref/proxy/all/salt.proxy.napalm.html Multiprocessing must be set to False for SSH-based proxies. However I had the same thought you did and tried it for sh*ts and giggles. |
@ggiesen Can you pull down the latest from the |
Will do. Working on building a proper Vagrant lab and I'll test as soon as it's done |
Initial impressions are that it is looking much, much better:
|
@ggiesen Excellent! Thanks for testing that out. I'm looking into the other issue of being able to have the connections happen in parallel to speed things up. |
Another issue: When the SSH session is dropped, it does not reconnect until the proxy is restarted:
Logs from when I disconnect the session:
Log from minion while executing above:
|
Note that using I'll try spinning up another unpatched vagrant lab to confirm. |
Unpatched 3003 still exhibits same behaviour. So probably not deltaproxy related. Going to revalidate on 3001 for my own sanity ;) |
Okay, I'm not crazy. Tried on 3001.7 and the regular proxy minion will reconnect: Session is connected:
Kill connection:
Logs from salt-proxy confirms disconnect:
User is definitely disconnected from router:
A few tens of seconds later:
Amd session and is reconnected:
Will try with 3002 next and then 3003 again. |
Confirmed 3002.6 works properly as well: Session is connected:
Kill connection:
Logs from salt-proxy confirms disconnect:
User is definitely disconnected from router:
A few tens of seconds later:
Amd session and is reconnected:
|
Reconfirmed 3003 is broken. It's actually this bug: #60025 (and it's not cosmetic) |
@ggiesen To confirm, this is not an issue with the deltaproxy changes but that other issue that you linked? |
@garethgreenaway that's correct. The patch made in the other issue has caused some new issues as well, and while they do solve the reconnect issue for regular proxy minions, they do not solve it for deltaproxy |
@ggiesen Found the issue and updated the |
@garethgreenaway After the latest changes in 4a1efd0, deltaproxy now reconnects automatically with no intervention on the part of the user: Session is killed:
Session is automatically reconnected:
|
Description
A number of issues related to the open-sourcing of deltaproxy in PR #60090 when using NAPALM as the proxy type.
router1:
router2:
router3:
Setup
Salt master and proxy are running 3003 with patches from #60090
/etc/salt/proxy:
/srv/pillar/top.sls:
/srv/pillar/deltaproxy.sls:
/srv/pillar/router1.sls:
/srv/pillar/router2.sls:
/srv/pillar/router3.sls:
Steps to Reproduce the behavior
$ salt-proxy --proxyid=deltaproxy -l debug
Expected behavior
Screenshots
If applicable, add screenshots to help explain your problem.
Versions Report
salt --versions-report
(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)Additional context
Using NAPALM 3.2.0
The text was updated successfully, but these errors were encountered: