-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Closed
Labels
DeprecationFeaturenew functionality including changes to functionality and code refactors, etc.new functionality including changes to functionality and code refactors, etc.
Milestone
Description
Is your feature request related to a problem? Please describe.
The __utils__ dunder(salt loader) tries to provide easy access to Salt's utility modules.
Issues with this approach:
- Utility functions should not be available in dunders, they are utility functions.
- All utilities are compacted into
<module>.<funcname>, which does not recurse into submodules. - This kind of usage, is prone to memory leaks(because utilities were not coded to work within a salt loader context). See fix memory leak in utils/jinja.py #62007 and fix yamlloader.DuplicateKeyWarning leaking #62021
Potential problems if we remove __utils__:
- Utility functions aren't available in jinja templating for salt states.
- They shouldn't, jinja uses it's own filters and Salt provides additional filters
Describe the solution you'd like
Completely remove support for __utils__
Describe alternatives you've considered
None.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
DeprecationFeaturenew functionality including changes to functionality and code refactors, etc.new functionality including changes to functionality and code refactors, etc.
Type
Projects
Status
No status