You can clone with
HTTPS or Subversion.
Not sure if this is intentional, but it took me a while to figure out what was going on. Turns out I had an old version of my module in site-packages/salt/modules/, very frustrating.
I would think that the system installed modules should override custom modules otherwise you could (potentially) run into issues when you override builtin salt modules accidentally and things start subtly breaking.
What do you think?
If I recall my intentions, it was that the _modules overrode the system modules, I thought this was the behavior, but it seems that blast was running into problems here.
Regardless of what we choose, it needs to be clean, deterministic and documented
I can see advantages on both sides, I think _modules should override the builtin modules, but maybe this could be a /etc/salt/minion configuration option? I think using system modules, states, etc over custom ones should be the default, but we should have a way to do that. It would make developing extensions to existing system modules /much/ easier.
Sounds reasonable to me.
My votes for having _modules always override. I'm not sure about making this configurable since they're just python modules and there is already a good system for managing those.
yes, _modules should allow you to override or add to an existing module, logging this event would not be a bad idea
SEJeff, Before I try and make this happen, any thoughts?
This should only require making sure the loader is bringing thing up in the right order, look at loader.py
@blast-hardcheese Consensus wins. So long as this behavior is enforced AND documented works for me. Salt is only as strong as it's community.
I asked in channel, but just in case I'm AFK when someone sees it, I'm asking again here. I made the required modification to loader.py, but then noticed that render and grains could be refactored to also use _create_loader. Anyway, comments welcome: loader_restructure
I like it blast! The only thing I would change is that we use .format to manage strings, but I like the modification and the fact that it unifies the loading interface, thanks!
@blast-hardcheese Nice! When you're done, would you mind unifying it all like you said?
@thatch45: Changed string formatting to .format
@SEJeff: Sorry, memory might be faulty here; what are you referring to?
Thanks blast, I am excited to get this pull req!
@blast-hardcheese disregard, I'm a bit loopy from working 12 hours yesterday and a 5-6 today for $real_job. Just a bit out of it I guess.
@SEJeff No worries!
Closed out with f8d3bf8
This appears to still be happening for me on 0.15.1?
Odd, you are sure the module is being distributed to the minion?