Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide vpc exists support #14601

Merged
merged 3 commits into from Aug 4, 2014

Conversation

@colinbjohnson
Copy link
Contributor

commented Jul 29, 2014

No description provided.

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/6481/

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/6511/

@colinbjohnson

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2014

The reason for this PR is to allow the boto_asg module (or other modules that work with or will work with AWS Auto Scaling) to determine what VPC an Auto Scaling Group is associated with. By calling boto_vpc.get_subnet_association and providing a string or list of ASG vpc_zone_identifiers (which Amazon more frequently refers to as subnets - hence the name) the VPC that an ASG is associated with can be returned. The information about VPC association can then be used to determine additional information that may be required for Auto Scaling Group or Launch Configuration creation - for instance, if a Launch Configuration utilizes Security Group names ['Default', 'API'] and is a member of a VPC, these Group Names must be converted to Security Group IDs - and this conversion requires that the VPC ID be known.

@thedrow

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2014

This finally resolves #6448. While you're at it, care to resolve #6447 as well?

@colinbjohnson

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2014

@thedrow - I would consider resolving #6447. I've sent you an email as it'd be good to get a couple of folks to work on this together.

@colinbjohnson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2014

Note that the contents of this pull request are included as part of #14701. Practically speaking, if #14701 is merged than the changes in this PR (#14601) are not required.

thatch45 added a commit that referenced this pull request Aug 4, 2014

@thatch45 thatch45 merged commit 77d709a into saltstack:develop Aug 4, 2014

1 check failed

default Merged build finished.
Details
@thatch45

This comment has been minimized.

Copy link
Member

commented Aug 4, 2014

I will merge them both seperatly, thanks!

@colinbjohnson colinbjohnson deleted the lyft:provide-vpc-exists-support branch Aug 9, 2014

@ryan-lane

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2014

@basepi please backport this to 2014.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.