Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide support for VPC security groups in boto_secgroup state module #14772

Merged
merged 1 commit into from Aug 7, 2014

Conversation

@colinbjohnson
Copy link
Contributor

commented Aug 5, 2014

This module provides vpc support for the boto_secgroup state module.

Functional test plan was completed and is described below:

EC-VPC Security Group Tests

Testing Present from Not Present

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1
- vpc_id: vpc-379b3952

Testing Present and No Change

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1
- vpc_id: vpc-379b3952

Testing Present and Update - Authorize Rule

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1
- vpc_id: vpc-379b3952
- rules:
- ip_protocol: tcp
from_port: 22
to_port: 22
cidr_ip: 10.0.0.0/8

Testing Present and Update - Authorize/Revoke Rule

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1
- vpc_id: vpc-379b3952
- rules:
- ip_protocol: tcp
from_port: 80
to_port: 80
cidr_ip: 10.0.0.0/8

Testing Present and Update - Revoke Rule

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1
- vpc_id: vpc-379b3952

Testing Absent

Ensure gateway security group absent:
boto_secgroup.absent:
- name: gateway
- description: gateway security group
- region: us-east-1
- vpc_id: vpc-379b3952

Testing Absent when Absent

Ensure gateway security group absent:
boto_secgroup.absent:
- name: gateway
- description: gateway security group
- region: us-east-1
- vpc_id: vpc-379b3952

EC2-Classic Security Group Tests

Testing Present from Not Present

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1

Testing Present and No Change

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1

Testing Present and Update - Authorize Rule

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1
- rules:
- ip_protocol: tcp
from_port: 22
to_port: 22
cidr_ip: 10.0.0.0/8

Testing Present and Update - Authorize/Revoke Rule

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1
- rules:
- ip_protocol: tcp
from_port: 80
to_port: 80
cidr_ip: 10.0.0.0/8

Testing Present and Update - Revoke Rule

Ensure gateway security group exists:
boto_secgroup.present:
- name: gateway
- description: gateway security group
- region: us-east-1

Testing Absent

Ensure gateway security group absent:
boto_secgroup.absent:
- name: gateway
- description: gateway security group
- region: us-east-1

Testing Absent when Absent

Ensure gateway security group absent:
boto_secgroup.absent:
- name: gateway
- description: gateway security group
- region: us-east-1

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/6700/

thatch45 added a commit that referenced this pull request Aug 7, 2014
Merge pull request #14772 from lyft/boto_secgroup-states-support-vpc
provide support for VPC security groups in boto_secgroup state module

@thatch45 thatch45 merged commit 0e87a59 into saltstack:develop Aug 7, 2014

1 check passed

default Merged build finished.
Details
@thatch45

This comment has been minimized.

Copy link
Member

commented Aug 7, 2014

Once these have settle more I am going to do a bulk audit

@ryan-lane

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2014

@basepi please backport to 2014.7

@colinbjohnson colinbjohnson deleted the lyft:boto_secgroup-states-support-vpc branch Sep 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.