Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boto vpc boto secgroup resolve unit test failures #15012

Conversation

@colinbjohnson
Copy link
Contributor

commented Aug 15, 2014

No description provided.

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/6978/

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2014

Closing to re-run the tests!

@rallytime rallytime closed this Aug 15, 2014

@rallytime rallytime reopened this Aug 15, 2014

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/6996/

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2014

@colinbjohnson Thanks for your work here! We are getting close. It looks like Ubuntu12 still isn't quite handling something correctly here. Can you take another look? Does the patch you applied to boto_secgroup_test also need to be applied to boto_vpc_test?

@colinbjohnson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2014

Got it. Two issues, both related to boto version:

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/7002/

@colinbjohnson

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2014

@rallytime - got the two patches in to allow unit tests to run - or to avoid being run. We've deprecated support for older versions of the Boto library, and the execution modules and state modules now reflect that change.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2014

Awesome! Thanks @colinbjohnson! We've been having some trouble with our test suite the last couple of days. I'm going to close this and reopen to run them again, as I think the issue has resolved.

@rallytime rallytime closed this Aug 19, 2014

@rallytime rallytime reopened this Aug 19, 2014

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/7061/

@rallytime rallytime closed this Aug 19, 2014

@rallytime rallytime reopened this Aug 19, 2014

region = 'us-east-1'
access_key = 'GKTADJGHEIQSXMKKRBJ08H'
secret_key = 'askdjghsdfjkghWupUjasdflkdfklgjsdfjajkghs'
conn_parameters = {'region': region, 'key': access_key, 'keyid': secret_key, 'profile': {}}


@skipIf(NO_MOCK, NO_MOCK_REASON)

This comment has been minimized.

Copy link
@rallytime

rallytime Aug 19, 2014

Contributor

@colinbjohnson Can you add this skipIf back in? It's needed for the test suite. It should go at the top of the class with the other skipIfs.

This comment has been minimized.

Copy link
@colinbjohnson

colinbjohnson Aug 19, 2014

Author Contributor

@rallytime - got it. Submitted a commit with the skipIf for NO_MOCK.

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/7066/

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/7069/

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2014

Sorry for all of the trouble here. I had to stop the tests because they were hanging. Trying one more time!

@rallytime rallytime closed this Aug 19, 2014

@rallytime rallytime reopened this Aug 19, 2014

@salt-jenkins

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/7072/

rallytime added a commit that referenced this pull request Aug 19, 2014
Merge pull request #15012 from lyft/boto_vpc-boto_secgroup-resolve-un…
…it-test-failures

Boto vpc boto secgroup resolve unit test failures

@rallytime rallytime merged commit 37420df into saltstack:develop Aug 19, 2014

1 check failed

default Merged build finished.
Details
@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2014

Awesome! There is still a quirky failure, but I can clean that up. I've verified that the tests run as expected on both Ubuntu 14 and Ubuntu 12, even though they didn't quite run here. Thanks for your work here @colinbjohnson!

@colinbjohnson colinbjohnson deleted the lyft:boto_vpc-boto_secgroup-resolve-unit-test-failures branch Aug 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.