set systemd service killMode to process for minion #23000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes saltstack#22993. The change is only made for the minion process because, theoretically, only the minion could create the problem described. salt-master and salt-syndic do not theoretically spawn non-salt processes during the lifetime of their processes, whereas salt-minion does this by design. The default behavior for systemd killMode seems to be control-group, which means all processes that share the same control group as the minion process will also be killed by systemd when the minion service is stopped (killed). It is reasonable to expect that activity done on a system by a salt minion should persist beyond the lifetime of the minion process, so let's not kill procs that the minion starts even when the minion exits.
thatch45
added a commit
that referenced
this pull request
Apr 24, 2015
set systemd service killMode to process for minion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22993.
The change is only made for the minion process because, theoretically,
only the minion could create the problem described. salt-master and
salt-syndic do not theoretically spawn non-salt processes during the
lifetime of their processes, whereas salt-minion does this by design.
The default behavior for systemd
killModeseems to becontrol-group,which means all processes that share the same control group as the
minion process will also be killed by systemd when the minion service is
stopped (killed).
It is reasonable to expect that activity done on a system by a salt
minion should persist beyond the lifetime of the minion process, so
let's not kill procs that the minion starts even when the minion exits.