New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle all exceptions gitpython can raise #23965

Merged
merged 1 commit into from May 20, 2015

Conversation

Projects
None yet
2 participants
@hvnsweeting
Contributor

hvnsweeting commented May 20, 2015

and make the code cleaner.

initially, I handle the exception by:

except (gitdb.exc.BadObject, gitdb.exc.BadName):

but it will fail if user use old version of gitdb, because gitdb.exc.BadName only added since gitpython-developers/gitdb@7bde7b0 , only available in 0.6.4+.

handle all exception gitpython can raise
and make the code cleaner
@msteed

This comment has been minimized.

Contributor

msteed commented May 20, 2015

@hvnsweeting - looks good, thank you!

msteed added a commit that referenced this pull request May 20, 2015

Merge pull request #23965 from hvnsweeting/20147-fix-gitfs-gitpython-…
…exception

handle all exceptions gitpython can raise

@msteed msteed merged commit 314e4db into saltstack:2014.7 May 20, 2015

3 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #5228 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #5883 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #5665 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #5233 — SUCCESS
Details

@hvnsweeting hvnsweeting deleted the hvnsweeting:20147-fix-gitfs-gitpython-exception branch Jun 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment