Make LocalClient.cmd_iter_no_block() not block #24093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional 'block' parameter to LocalClient.get_iter_returns(). Pass block=False in cmd_iter_no_block() so it can yield when no returns are available. Fixes saltstack#23464
|
@msteed, it looks like a test needs to be updated. |
- In Batch.__gather_minions(), call cmd_iter() instead of cmd_iter_no_block(), since the effect was to block inside __gather_minions() anyway, and the timeout was already being passed to cmd_iter() - Tidy up some docstrings
|
@jfindlay, thanks. The test was right; I had introduced a bug. |
|
Nice! |
rallytime
pushed a commit
that referenced
this pull request
May 25, 2015
Make LocalClient.cmd_iter_no_block() not block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional
blockparameter toLocalClient.get_iter_returns(). Passblock=Falseincmd_iter_no_block()so it can yield when no returns are available. Fixes #23464,