Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
bugfix: trailing "...done" in rabbitmq output #24511
Some versions of rabbitmq (v3.4.1) do not output any final "...done" line in output of listings, but the given salt code unconditionally removed the final line of output, which may often result in inconsistent behavior of dependent state functions, where the final line has a value that is significant.
This bugfix changes this output manipulation to be conditional, matching only lines of
In my environment::
This causes issues in, for example, a vhost is attempted to be created for '/' that already exists, if that vhost happens to be the last one listed in command output, it is thought non-existant, resulting in state failure::
Thanks @jquast - tests too! :) It looks like you have some minor pylint errors. Can you grab those really quickly?
Also, it looks like your changes are affecting some of the other tests. Can you take a look at those as well? If you get stuck let us know and we can help out. Thanks again!
added a commit
this pull request
Jun 11, 2015
Jun 11, 2015
3 of 5 checks passed
@rallytime nevermind regarding 2014.7, this bugfix present in 2015.8. I am submitting PR for 2015.5.
(i just helped bugfix the 2014.7 branch this past day due to a mis-backportted bugfix made the previous by your staff, which made me question why this bugfix is not included in the branch: if 2014.7 really is inactive, that's ok.)
@jquast There are still a couple of people submitting changes to 2014.7 and we are still doing "merge-forwards" from that branch. If people choose to pull from the branch, then they can. The difference is that we just won't be releasing from that branch any more. Our current release branch is 2015.5. Anyway, thanks for taking care of that. :)