New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix use of 'iteritem' in 2014.7 branch #24513

Merged
merged 1 commit into from Jun 9, 2015

Conversation

Projects
None yet
2 participants
@jquast
Contributor

jquast commented Jun 8, 2015

improper use of dict type 'iteritem', should be 'iteritems'.

This was discovered when combined with bugfix #24511, where previously such code could not have been exercised with more than 1 vhost.

@rallytime

This comment has been minimized.

Contributor

rallytime commented Jun 9, 2015

Good catch!

rallytime added a commit that referenced this pull request Jun 9, 2015

Merge pull request #24513 from jquast/2014.7-bugfix-iteritem
bugfix use of 'iteritem' in 2014.7 branch

@rallytime rallytime merged commit 6ebc476 into saltstack:2014.7 Jun 9, 2015

3 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-linode-cent7-n Salt PR - Linode CentOS 7 #443 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #6632 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #6412 — SUCCESS
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #5975 — SUCCESS
Details

@jquast jquast deleted the jquast:2014.7-bugfix-iteritem branch Jun 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment