Fixed comment and uncomment functions in file.py #24620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! It passed lint! |
|
Fixes #24215 |
jfindlay
added
Platform
UtahDave
added a commit
that referenced
this pull request
Jun 12, 2015
Fixed comment and uncomment functions in file.py
twangboy
added
Bug
| limit=regex.lstrip('^'), | ||
| backup=backup) | ||
| pattern = '^{0}{1}'.format(char, regex.lstrip('^').rstrip('$')) | ||
| repl = "{0}".format(regex.lstrip('^').rstrip('$')) |
There was a problem hiding this comment.
This is completely wrong! You are replacing the matched pattern with the regex itself.
This can only work if you don't actually use a regular expression.
For example if you try to uncomment level = (warning|error) and the file contains # level = warning it will be replaced with level = (warning|error).
There was a problem hiding this comment.
@mtorromeo Thanks. I'll take a look at and see if I can figure out a better solution.
|
The change is not backward compatible: new version does not recognize "[[:space:]]*" in the beginning, just after the comment char. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comment and uncomment now use file.replace
-- Need someone to double check the regex stuff
Added comment/uncomment to the win_file.py
Tested with states