Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tomcat module fails to extract version number from snapshot builds #2… #24927

Closed
wants to merge 2 commits into from
Closed

Tomcat module fails to extract version number from snapshot builds #2… #24927

wants to merge 2 commits into from

Conversation

egarbi
Copy link
Contributor

@egarbi egarbi commented Jun 24, 2015

This patch come form @nvx I have tested on my configuration and works. I really need this it is causing a big problem on our servers at this moment.
Issue #24520

@jfindlay jfindlay added Minor Change Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels Jun 24, 2015
@jfindlay
Copy link
Contributor

@egarbi, thanks for the fix. There are some test errors:
https://jenkins.saltstack.com/job/salt-pr-lint-n/6873/violations/file/salt/states/tomcat.py/
https://jenkins.saltstack.com/job/salt-pr-rs-ubuntu14.04-n/6436/testReport/junit/unit.states.tomcat_test/TomcatTestCase/test_war_deployed/

@egarbi
Copy link
Contributor Author

egarbi commented Jun 30, 2015

Can anyone help me to pass this test errors?, I have no idea how to do it by myself

@jfindlay jfindlay self-assigned this Jun 30, 2015
@jfindlay
Copy link
Contributor

@egarbi, I'll look into it.

@jfindlay jfindlay mentioned this pull request Jul 8, 2015
Merged
@jfindlay jfindlay removed their assignment Jul 8, 2015
@egarbi egarbi closed this Jul 9, 2015
@egarbi
Copy link
Contributor Author

egarbi commented Jul 9, 2015

@jfindlay has a better PR for this one, thanks!!

@egarbi egarbi deleted the 2015.5 branch July 9, 2015 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform Relates to OS, containers, platform-based utilities like FS, system based apps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@egarbi @jfindlay