New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove only the file extension when checking missing cached nodes. #27104

Merged
merged 1 commit into from Sep 14, 2015

Conversation

Projects
None yet
5 participants
@hexedpackets
Contributor

hexedpackets commented Sep 14, 2015

With string.replace every substring of '.p' would be removed, causing incorrect minion IDs. For example, a minion ID of 'production.postgres' would be cached under the filename 'production.postgres.p' but would be loaded as 'productionostgres'.

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Sep 14, 2015

Contributor

Nice catch here! Not sure how that mistake managed to make it in there. Glad you caught this.

Contributor

cachedout commented Sep 14, 2015

Nice catch here! Not sure how that mistake managed to make it in there. Glad you caught this.

cachedout added a commit that referenced this pull request Sep 14, 2015

Merge pull request #27104 from hexedpackets/develop
Remove only the file extension when checking missing cached nodes.

@cachedout cachedout merged commit 1c7b318 into saltstack:develop Sep 14, 2015

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #578 — FAILURE
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #8052 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #9502 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #9223 — SUCCESS
Details
@vutny

This comment has been minimized.

Show comment
Hide comment
@vutny

vutny Dec 29, 2015

Contributor

@cachedout @jfindlay Could you please cherry-pick this particular commit 86d063f to the 2015.8 branch? Because this silly bug still affects stable release.

Contributor

vutny commented Dec 29, 2015

@cachedout @jfindlay Could you please cherry-pick this particular commit 86d063f to the 2015.8 branch? Because this silly bug still affects stable release.

@rallytime

This comment has been minimized.

Show comment
Hide comment
@rallytime

rallytime Dec 29, 2015

Contributor

Thanks for the bump, @vutny. I've back-ported this in #30060.

Contributor

rallytime commented Dec 29, 2015

Thanks for the bump, @vutny. I've back-ported this in #30060.

cachedout added a commit that referenced this pull request Dec 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment