Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refresh_db regression in yumpkg.py #27308

Merged
merged 1 commit into from Sep 22, 2015

Conversation

terminalmage
Copy link
Contributor

739b2ef introduced a regression by changing this function to passing a list of
arguments. The regression was also partly caused by requiring the user to pass
the yum CLI arguments for enabling and disabling repos manually. So if someone
passed multiple values for the repo argument
(e.g. repo='--disablerepo="*" --enablerepo=anotherrepo') then these would both
end up in the same list element, which would cause the yum command to fail as
they would be expected by yum to be a single argument instead of separate
arguments.

This commit reverts the changes from 739b2ef and also changes the inconsistent
behavior of requiring the repo options to be manually submitted, making this
function instead work like all the other functions (install(), etc.) which
interpret the Salt CLI kwargs to figure out which repo options to use.

Fixes #27307.

739b2ef introduced a regression by changing this function to passing a
list of arguments. The regression was also partly caused by requiring
the user to pass the yum CLI arguments for enabling and disabling repos
manually. So if someone passed multiple values for the repo argument
(e.g. repo='--disablerepo="*" --enablerepo=anotherrepo') then these
would both end up in the same list element, which would cause the yum
command to fail as they would be expected by yum to be a single argument
instead of separate arguments.

This commit reverts the changes from 739b2ef and also changes the
inconsistent behavior of requiring the repo options to be manually
submitted, making this function instead work like all the other
functions (install(), etc.) which interpret the Salt CLI kwargs to
figure out which repo options to use.

Fixes saltstack#27307.
basepi added a commit that referenced this pull request Sep 22, 2015
@basepi basepi merged commit 982c21c into saltstack:2015.5 Sep 22, 2015
@terminalmage terminalmage deleted the fix-refresh_db-regression branch October 8, 2015 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants