Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
docker-py expect only `command` argument not `cmd` #27444
referenced this pull request
Sep 27, 2015
I'd also add that there is no such thing as "natural to the module", but "consistent with the Salt". For example, there are many things that are natural to a Zypper, a bit natural to the Yum, but absolutely unnatural to the Dpkg. But at the end it should be all the same. Same applies to the different filesystems, where the same operations should be called the same way, e.g. you "mount", not "connect" or "attach" or "publish" etc.
@isbm Thank you for the detailed explanations.
I understand salt encapsulation is strong over utilities that are gathered under the same umbrella. But for standalone api like docker, when salt Interface shadows docker api I think it brings more complexity. Because I never been able to achieve my goals without understand docker api. At the end, I feel more comfortable with docker api. In this scenario salt become "just" a
So, thank you again for your answer, I understand better, and long live to
OK, after looking at this, the fix from @ticosax is good after all. I misread it yesterday when I was in the middle of working on something else.
The issue here is that I did things backwards. I should have made
There were some differences in the docstrings and comments that I wanted to make, so I opened a new PR (#27459) for this. I then incorporated the additional test from @ticosax into that PR, with a slightly modified commit message.
There is no deprecation to be done, both arguments will be accepted and equivalent, as explained in the docstrings for the