New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #19673 #28175

Merged
merged 1 commit into from Oct 21, 2015

Conversation

Projects
None yet
2 participants
@twangboy
Contributor

twangboy commented Oct 21, 2015

It was checking if start or end was False. None, 0, and '' evaluate to False so
0 was being evaluated as an invalid parameter for start and end. Changed it to
specifically check for None and ''. 0 is a valid value for start and end.

Fixes #19673

Fixes #19673
It was checking if start or end was False. None, 0, and '' evaluate to False so
0 was being evaluated as an invalid parameter for start and end. Changed it to
specifically check for None and ''. 0 is a valid value for start and end.

cachedout added a commit that referenced this pull request Oct 21, 2015

@cachedout cachedout merged commit 2225925 into saltstack:2015.5 Oct 21, 2015

5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #10491 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #1556 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #10201 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #9030 — SUCCESS
Details

@twangboy twangboy deleted the twangboy:fix_19673 branch Feb 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment