New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing and documentation pages to recommend submitting against branches #28529

Merged
merged 2 commits into from Nov 4, 2015

Conversation

Projects
None yet
3 participants
@rallytime
Contributor

rallytime commented Nov 3, 2015

Fixes #28272

@gravyboat

This comment has been minimized.

Show comment
Hide comment
@gravyboat

gravyboat Nov 3, 2015

Member

@rallytime This looks really good! What do you think about adding a few examples for users showing how they can pull a specific tag?

Member

gravyboat commented Nov 3, 2015

@rallytime This looks really good! What do you think about adding a few examples for users showing how they can pull a specific tag?

@rallytime

This comment has been minimized.

Show comment
Hide comment
@rallytime

rallytime Nov 3, 2015

Contributor

I thought about that, and started to add some examples, and then I realized I was repeating a lot what we were stating in the Contributing docs here.

Maybe I can add some "for an example of how to submit a PR against another branch, see XXX" and update the language in that section to also apply to docfixes. Would that work @gravyboat?

Contributor

rallytime commented Nov 3, 2015

I thought about that, and started to add some examples, and then I realized I was repeating a lot what we were stating in the Contributing docs here.

Maybe I can add some "for an example of how to submit a PR against another branch, see XXX" and update the language in that section to also apply to docfixes. Would that work @gravyboat?

@gravyboat

This comment has been minimized.

Show comment
Hide comment
@gravyboat

gravyboat Nov 3, 2015

Member

@rallytime I think that would be a good addition. I'd rather double up on commands that need to be run directly than rely on users having navigated the pages in a specific way. The linking seems like a good compromise to that! 👍

Member

gravyboat commented Nov 3, 2015

@rallytime I think that would be a good addition. I'd rather double up on commands that need to be run directly than rely on users having navigated the pages in a specific way. The linking seems like a good compromise to that! 👍

@rallytime

This comment has been minimized.

Show comment
Hide comment
@rallytime

rallytime Nov 3, 2015

Contributor

Thanks! Sounds good! I've updated my PR.

Contributor

rallytime commented Nov 3, 2015

Thanks! Sounds good! I've updated my PR.

@gravyboat

This comment has been minimized.

Show comment
Hide comment
@gravyboat

gravyboat Nov 3, 2015

Member

Looks great @rallytime! :shipit:

Member

gravyboat commented Nov 3, 2015

Looks great @rallytime! :shipit:

cachedout added a commit that referenced this pull request Nov 4, 2015

Merge pull request #28529 from rallytime/fix-28272
Update contributing and documentation pages to recommend submitting against branches

@cachedout cachedout merged commit 6acf875 into saltstack:2015.5 Nov 4, 2015

5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #10881 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #1950 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #10591 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #9420 — SUCCESS
Details

@rallytime rallytime deleted the rallytime:fix-28272 branch Nov 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment