New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use S3 credentials from Pillar #28630

Merged
merged 3 commits into from Nov 11, 2015

Conversation

Projects
None yet
6 participants
@messa
Contributor

messa commented Nov 5, 2015

I want to use file.managed with source from AWS S3 and store S3 credentials in Pillar, like it is mentioned in documentation:

  • salt.states.file says Both HTTPS and HTTP are supported as well as downloading directly from Amazon S3 compatible URLs with both pre-configured and automatic IAM credentials. (see s3.get state documentation)
  • well, there appears to be no s3 state. only s3 module
  • salt.modules.s3 says that I can store s3.keyid and s3.key ... either in a pillar or in the minion's config file

But it looks that Salt allows S3 credentials only in minion config file (or EC2 instance metadata): #13850 and possibly #26911

Since I really want to use Pillar I fixed it myself and if you are interested it can be merged to the upstream. But maybe you are already working on a different way how to fix this.

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Nov 6, 2015

Contributor

@messa This looks OK but I'm wondering if we should prefer the pillar value over the config value?

Contributor

cachedout commented Nov 6, 2015

@messa This looks OK but I'm wondering if we should prefer the pillar value over the config value?

@messa

This comment has been minimized.

Show comment
Hide comment
@messa

messa Nov 9, 2015

Contributor

@cachedout I don't know :) Currently (in 4d38687) is the config value preferred. Should I change it so the pillar value is preferred?

Contributor

messa commented Nov 9, 2015

@cachedout I don't know :) Currently (in 4d38687) is the config value preferred. Should I change it so the pillar value is preferred?

@techhat

This comment has been minimized.

Show comment
Hide comment
@techhat

techhat Nov 9, 2015

Member

It seems to me that the order used in config.get would probably be preferable.

Also, +1 on this PR. It's good stuff.

Member

techhat commented Nov 9, 2015

It seems to me that the order used in config.get would probably be preferable.

Also, +1 on this PR. It's good stuff.

cachedout added a commit that referenced this pull request Nov 11, 2015

Merge pull request #28630 from messa/201511-messa-s3-fixes
Use S3 credentials from Pillar

@cachedout cachedout merged commit 6e2003e into saltstack:develop Nov 11, 2015

5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #10965 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #2034 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #10675 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #9504 — SUCCESS
Details
@meggiebot

This comment has been minimized.

Show comment
Hide comment
@meggiebot

meggiebot Nov 17, 2015

Need this in 2015.8 and 2015.5 branches

meggiebot commented Nov 17, 2015

Need this in 2015.8 and 2015.5 branches

cachedout added a commit that referenced this pull request Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment