New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-port #28718 to 2015.5 #28746

Merged
merged 1 commit into from Nov 10, 2015

Conversation

Projects
None yet
3 participants
@rallytime
Contributor

rallytime commented Nov 10, 2015

Back-port #28718 to 2015.5

Account for no POST data
The serving.request doesn't include a raw_body when the POST data
is blank, so set it to an empty dict.

Also fixed a bug where we assumed that if data wasn't a list, it
was a dict, which bombs because null POSTS result in None.

@rallytime rallytime changed the title from Back-port #28717 to 2015.5 to Back-port #28718 to 2015.5 Nov 10, 2015

cachedout added a commit that referenced this pull request Nov 10, 2015

@cachedout cachedout merged commit 6f8f049 into saltstack:2015.5 Nov 10, 2015

3 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #2160 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #11091 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #10801 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #9630 — SUCCESS
Details

@rallytime rallytime deleted the rallytime:bp-28718 branch Nov 10, 2015

@whiteinge

This comment has been minimized.

Show comment
Hide comment
@whiteinge

whiteinge Nov 11, 2015

Contributor

Thank you!

On Tue, Nov 10, 2015 at 9:09 AM, Nicole Thomas notifications@github.com
wrote:

Back-port #28717 #28717 to 2015.5

You can view, comment on, or merge this pull request online at:

#28746
Commit Summary

  • Account for no POST data

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#28746.

Contributor

whiteinge commented Nov 11, 2015

Thank you!

On Tue, Nov 10, 2015 at 9:09 AM, Nicole Thomas notifications@github.com
wrote:

Back-port #28717 #28717 to 2015.5

You can view, comment on, or merge this pull request online at:

#28746
Commit Summary

  • Account for no POST data

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#28746.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment