New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pydsl tests to integration test suite #29170

Merged
merged 3 commits into from Nov 25, 2015

Conversation

Projects
None yet
3 participants
@cachedout
Contributor

cachedout commented Nov 24, 2015

This marks the beginning of a migration of the pydsl renderer tests
to the integration test suite and away from the unit test suite.

The unit test approach is becoming too difficult to maintain due to its complex approach to trying to internally manage a highstate run instead of calling into the salt state system to fully manage it.

This PR currently has some test paths hardcoded for temporary files, which is not acceptable in the long-term. This is due to what appears to be a bug either in the test suite or in the pydsl renderer which seems to prevent custom Salt modules from being loaded.

Migrate pydsl tests to integration test suite
This marks the beginning of a migration of the pydsl renderer tests
to the integration test suite and away from the unit test suite.

The unit test approach is becoming too difficult to maintain due to its complex approach to trying to internally manage a highstate run instead of calling into the salt state system to fully manage it.
@s0undt3ch

This comment has been minimized.

Show comment
Hide comment
@s0undt3ch

s0undt3ch Nov 24, 2015

Member

Please confirm that Jenkins picks up the integration test.... our runtests script is quite picky to finding tests....

Member

s0undt3ch commented Nov 24, 2015

Please confirm that Jenkins picks up the integration test.... our runtests script is quite picky to finding tests....

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Nov 25, 2015

Contributor

@s0undt3ch Good call. They were not being picked up. I pushed a change that should resolve that. Thanks!

Contributor

cachedout commented Nov 25, 2015

@s0undt3ch Good call. They were not being picked up. I pushed a change that should resolve that. Thanks!

cachedout added a commit that referenced this pull request Nov 25, 2015

Merge pull request #29170 from cachedout/refactor_pydsl_test
Migrate pydsl tests to integration test suite

@cachedout cachedout merged commit 1937a47 into saltstack:2015.8 Nov 25, 2015

4 of 6 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent6-n Salt PR - RS CentOS 6 #223 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #11511 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #2578 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11219 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10048 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment