New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check service enable state in test mode #29218

Merged
merged 1 commit into from Dec 2, 2015

Conversation

Projects
None yet
3 participants
@clan
Contributor

clan commented Nov 26, 2015

add missing service enabled/disabled state check

Show outdated Hide outdated salt/states/service.py Outdated
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Nov 30, 2015

Contributor

Hi @clan. There's some unreachable code that I've commented on. Also, it does not look like tests are passing. Could you please take a look?

Contributor

cachedout commented Nov 30, 2015

Hi @clan. There's some unreachable code that I've commented on. Also, it does not look like tests are passing. Could you please take a look?

@clan

This comment has been minimized.

Show comment
Hide comment
@clan

clan Dec 1, 2015

Contributor

fixed, and repushed

Contributor

clan commented Dec 1, 2015

fixed, and repushed

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 1, 2015

Contributor

Go Go Jenkins!

Contributor

cachedout commented Dec 1, 2015

Go Go Jenkins!

@clan

This comment has been minimized.

Show comment
Hide comment
@clan

clan Dec 1, 2015

Contributor

no error log for centos 6 & 7, it seems like other problem unrelated to this pull request?

Contributor

clan commented Dec 1, 2015

no error log for centos 6 & 7, it seems like other problem unrelated to this pull request?

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 2, 2015

Contributor

Yup, unrelated. I'm going to go ahead and merge this now.

Contributor

cachedout commented Dec 2, 2015

Yup, unrelated. I'm going to go ahead and merge this now.

cachedout added a commit that referenced this pull request Dec 2, 2015

Merge pull request #29218 from clan/service_state
check service enable state in test mode

@cachedout cachedout merged commit 99b7d87 into saltstack:2015.8 Dec 2, 2015

3 of 6 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent6-n Salt PR - RS CentOS 6 #332 — FAILURE
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10157 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #11621 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #2689 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11330 — SUCCESS
Details

@clan clan deleted the clan:service_state branch Dec 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment