New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dockerng] Add support for volume management in dockerng #29300

Merged
merged 3 commits into from Dec 2, 2015

Conversation

Projects
None yet
3 participants
@ticosax
Contributor

ticosax commented Dec 1, 2015

fixes #28990

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 1, 2015

Contributor

Hi @ticosax Looks like a few Python 3 incompatability issues. Please take a look at the lint report and let me know what you think. Thanks!

Contributor

cachedout commented Dec 1, 2015

Hi @ticosax Looks like a few Python 3 incompatability issues. Please take a look at the lint report and let me know what you think. Thanks!

@ticosax

This comment has been minimized.

Show comment
Hide comment
@ticosax

ticosax Dec 1, 2015

Contributor

@cachedout thanks for the notification.
I pushed the fix

Contributor

ticosax commented Dec 1, 2015

@cachedout thanks for the notification.
I pushed the fix

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 1, 2015

Contributor

@ticosax Thank you for your quick response. Once the tests finish running I will have another look.

Contributor

cachedout commented Dec 1, 2015

@ticosax Thank you for your quick response. Once the tests finish running I will have another look.

def volumes(filters=None):
'''
List existing volumes

This comment has been minimized.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

def create_volume(name, driver=None, driver_opts=None):
'''
Create a new volume

This comment has been minimized.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

def remove_volume(name):
'''
Remove a volume

This comment has been minimized.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

def volume_present(name, driver=None, driver_opts=None):
'''
Ensure that a volume is present.

This comment has been minimized.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

def volume_absent(name, driver=None):
'''
Ensure that a volume is absent.

This comment has been minimized.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, .. versionadded:: 2015.8.4.

@jfindlay

This comment has been minimized.

Show comment
Hide comment
@jfindlay

jfindlay Dec 1, 2015

Contributor

@ticosax, I have added some comments, but otherwise, this looks really awesome.

Contributor

jfindlay commented Dec 1, 2015

@ticosax, I have added some comments, but otherwise, this looks really awesome.

@ticosax

This comment has been minimized.

Show comment
Hide comment
@ticosax

ticosax Dec 2, 2015

Contributor

@jfindlay Thanks, I amended the commits.

Contributor

ticosax commented Dec 2, 2015

@jfindlay Thanks, I amended the commits.

cachedout added a commit that referenced this pull request Dec 2, 2015

Merge pull request #29300 from ticosax/dockerng-volumes
[dockerng] Add support for volume management in dockerng

@cachedout cachedout merged commit 5ec7947 into saltstack:2015.8 Dec 2, 2015

4 of 6 checks passed

jenkins/salt-pr-rs-cent6-n Salt PR - RS CentOS 6 #363 — FAILURE
Details
default Merged build started.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #11653 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #2720 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11361 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10188 — SUCCESS
Details
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 2, 2015

Contributor

Looks great. Thanks @ticosax !

Contributor

cachedout commented Dec 2, 2015

Looks great. Thanks @ticosax !

@ticosax ticosax deleted the ticosax:dockerng-volumes branch Dec 2, 2015

@ticosax

This comment has been minimized.

Show comment
Hide comment
@ticosax

ticosax Dec 2, 2015

Contributor

@cachedout thanks, #28990 can be closed.

Contributor

ticosax commented Dec 2, 2015

@cachedout thanks, #28990 can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment