New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of ESXi Proxy Minion #29499

Merged
merged 17 commits into from Dec 8, 2015

Conversation

Projects
None yet
3 participants
@rallytime
Contributor

rallytime commented Dec 7, 2015

I still need to add some documentation and a couple of functions, but I wanted to get this in and tests running on it.

ping @cro

rallytime and others added some commits Nov 11, 2015

Initial commit of ESXi proxy work.
Update grains information to work properly

Added NTP functionality to vsphere module

Add ssh enable/disable capabilities

Allow list of host_names in ntp functions

Password update, ssh_restart, datetime management functionality added

Added enable/disable vsan and disk listing capabilities

Don't stack trace is VSAN System or VSAN Config are unset

Be able to provide a list of passwords via pillar to auth against a host

Fix bug with test.ping returning False, even though other functions work

Add ability to add blank host disks to host's vsan system

Minor bug fix for vsan_add_disks function
Merge pull request #11 from cro/esxi-proxy
Add functions for getting and setting network coredumps.
Merge pull request #13 from cro/esxi-proxy3
Add syslog config and network firewall rules enable
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 7, 2015

Contributor

This is very solid. After reading the whole thing, pretty much the only feedback I have here is that it would be helpful to include more in-line documentation for some of the longer fuctions but on the whole, this was a pleasure to read. Well done.

Contributor

cachedout commented Dec 7, 2015

This is very solid. After reading the whole thing, pretty much the only feedback I have here is that it would be helpful to include more in-line documentation for some of the longer fuctions but on the whole, this was a pleasure to read. Well done.

@rallytime

This comment has been minimized.

Show comment
Hide comment
@rallytime

rallytime Dec 7, 2015

Contributor

@cachedout Good point. There is a lot in here that could use some more explanation.

Contributor

rallytime commented Dec 7, 2015

@cachedout Good point. There is a lot in here that could use some more explanation.

cachedout added a commit that referenced this pull request Dec 8, 2015

Merge pull request #29499 from rallytime/esxi-proxy
Initial commit of ESXi Proxy Minion

@cachedout cachedout merged commit 3ae096b into saltstack:2015.8 Dec 8, 2015

4 of 6 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent6-n Salt PR - RS CentOS 6 #619 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #11875 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #2939 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11580 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10444 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment