New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored ESXCLI-based functions to accept a list of esxi_hosts #29547

Merged
merged 1 commit into from Dec 9, 2015

Conversation

Projects
None yet
2 participants
@rallytime
Contributor

rallytime commented Dec 9, 2015

Previously, only one esxi_host could be passed in when connecting
to a vCenter server. This brings feature-partiy for ESXCLI-based
functions with pyVmomi-based functions, which already accept and
handle a list of hosts.

State functions were also updated.

Also fixes a bug with the ESXCLI which check in salt.utils.vmware
and provides default protocol and port options if none are provided
for salt.utils.vmware.esxcli.

ping @cro

Refactored ESXCLI-based functions to accept a list of esxi_hosts
Previously, only one esxi_host could be passed in when connecting
to a vCenter server. This brings feature-partiy for ESXCLI-based
functions with pyVmomo-based functions, which already accept and
handle a list of hosts.

State functions were also updated.

Also fixes a bug with the ESXCLI which check in salt.utils.vmware
and provides default protocol and port options if none are provided.
@@ -62,7 +62,7 @@ def __virtual__():
return __virtualname__
def get_coredump_network_config(host, username, password, protocol=None, port=None, esxi_host=None):
def get_coredump_network_config(host, username, password, protocol=None, port=None, esxi_hosts=None):

This comment has been minimized.

@cachedout

cachedout Dec 9, 2015

Contributor

Are we sure we want to change a parameter name in a point release?

@cachedout

cachedout Dec 9, 2015

Contributor

Are we sure we want to change a parameter name in a point release?

This comment has been minimized.

@rallytime

rallytime Dec 9, 2015

Contributor

This code hasn't been released yet. I am just changing these parameters for functions that have been merged into Salt for less that a day. :)

@rallytime

rallytime Dec 9, 2015

Contributor

This code hasn't been released yet. I am just changing these parameters for functions that have been merged into Salt for less that a day. :)

This comment has been minimized.

@cachedout

cachedout Dec 9, 2015

Contributor

Ah, OK. No worries. Thanks.

@cachedout

cachedout Dec 9, 2015

Contributor

Ah, OK. No worries. Thanks.

cachedout added a commit that referenced this pull request Dec 9, 2015

Merge pull request #29547 from rallytime/esxi-proxy
Refactored ESXCLI-based functions to accept a list of esxi_hosts

@cachedout cachedout merged commit fd67903 into saltstack:2015.8 Dec 9, 2015

4 of 6 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent6-n Salt PR - RS CentOS 6 #638 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #11894 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #2958 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11599 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10463 — SUCCESS
Details

@rallytime rallytime deleted the rallytime:esxi-proxy branch Dec 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment