New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning security group when no VPC id is given #29558

Merged
merged 2 commits into from Dec 11, 2015

Conversation

Projects
None yet
4 participants
@ruxandraburtica
Contributor

ruxandraburtica commented Dec 9, 2015

No description provided.

@rallytime

This comment has been minimized.

Show comment
Hide comment
@rallytime

rallytime Dec 9, 2015

Contributor

@ruxandraburtica Thank you for submitting this change!

It looks like you've got some pylint errors. Would you mind fixing those up?

Contributor

rallytime commented Dec 9, 2015

@ruxandraburtica Thank you for submitting this change!

It looks like you've got some pylint errors. Would you mind fixing those up?

@ruxandraburtica

This comment has been minimized.

Show comment
Hide comment
@ruxandraburtica

ruxandraburtica Dec 9, 2015

Contributor

@rallytime fixed the errors, but there are still some jobs failing, are those tests known for failing?

Contributor

ruxandraburtica commented Dec 9, 2015

@rallytime fixed the errors, but there are still some jobs failing, are those tests known for failing?

@jfindlay

This comment has been minimized.

Show comment
Hide comment
@jfindlay

jfindlay Dec 9, 2015

Contributor

@ruxandraburtica, yes, those are known failures.

Contributor

jfindlay commented Dec 9, 2015

@ruxandraburtica, yes, those are known failures.

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 10, 2015

Contributor

Hi @ruxandraburtica . We don't typically raise exceptions in Salt execution modules. The typical pattern is to log an error message instead and, potentially, return information about what went wrong in the return. Is there a specific reason for this exception?

Contributor

cachedout commented Dec 10, 2015

Hi @ruxandraburtica . We don't typically raise exceptions in Salt execution modules. The typical pattern is to log an error message instead and, potentially, return information about what went wrong in the return. Is there a specific reason for this exception?

cachedout added a commit that referenced this pull request Dec 11, 2015

Merge pull request #29558 from ruxandraburtica/security-group-no-vpc-id
Returning security group when no VPC id is given

@cachedout cachedout merged commit 7a8d1d8 into saltstack:develop Dec 11, 2015

4 of 6 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent6-n Salt PR - RS CentOS 6 #654 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #11910 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #2974 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11615 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10479 — SUCCESS
Details

cachedout added a commit that referenced this pull request Dec 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment