New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pillar-based cloud providers still forcing use of deprecated 'provider' #29713

Merged
merged 3 commits into from Dec 16, 2015

Conversation

Projects
None yet
3 participants
@The-Loeki
Contributor

The-Loeki commented Dec 15, 2015

Similar to #27953

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 15, 2015

Contributor

@The-Loeki There are some minor lint errors here. Could you please have a look?

@techhat or @rallytime Could one of you please sign-off here?

Contributor

cachedout commented Dec 15, 2015

@The-Loeki There are some minor lint errors here. Could you please have a look?

@techhat or @rallytime Could one of you please sign-off here?

@rallytime

This comment has been minimized.

Show comment
Hide comment
@rallytime

rallytime Dec 15, 2015

Contributor

LGTM. Thanks @The-Loeki!

Contributor

rallytime commented Dec 15, 2015

LGTM. Thanks @The-Loeki!

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 15, 2015

Contributor

Thanks, @rallytime

@The-Loeki Please let me know when the lint issues have been fixed and we will get this in. Thanks!

Contributor

cachedout commented Dec 15, 2015

Thanks, @rallytime

@The-Loeki Please let me know when the lint issues have been fixed and we will get this in. Thanks!

@The-Loeki

This comment has been minimized.

Show comment
Hide comment
@The-Loeki

The-Loeki Dec 16, 2015

Contributor

sorry 'bout that @rallytime/@cachedout; all good now.

Contributor

The-Loeki commented Dec 16, 2015

sorry 'bout that @rallytime/@cachedout; all good now.

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 16, 2015

Contributor

No problem at all. Looks good now! Thanks, @The-Loeki

Contributor

cachedout commented Dec 16, 2015

No problem at all. Looks good now! Thanks, @The-Loeki

cachedout added a commit that referenced this pull request Dec 16, 2015

Merge pull request #29713 from The-Loeki/patch-1
Pillar-based cloud providers still forcing use of deprecated 'provider'

@cachedout cachedout merged commit b3f17fd into saltstack:2015.8 Dec 16, 2015

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3123 — FAILURE
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10630 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12059 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11761 — SUCCESS
Details

@The-Loeki The-Loeki deleted the The-Loeki:patch-1 branch Dec 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment