New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type mess in git.latest #29740

Merged
merged 1 commit into from Dec 16, 2015

Conversation

Projects
None yet
4 participants
@kiorky
Contributor

kiorky commented Dec 16, 2015

Did not get why, but we can have a list of comments instead of stings.

This fixes:

     line 107, in _uptodate\n    ret['comment'] += '\\n\\nChanges made: ' + comments\nTypeError:
      cannot concatenate 'str' and 'list' objects\n"
    duration: 366.804
    name: https://github.com/makinacorpus/makina-states.git
    result: false
Type mess in git.latest
Did not get why, but we can have a list of comments instead of stings.

This fixes:
```
     line 107, in _uptodate\n    ret['comment'] += '\\n\\nChanges made: ' + comments\nTypeError:
      cannot concatenate 'str' and 'list' objects\n"
    duration: 366.804
    name: https://github.com/makinacorpus/makina-states.git
    result: false
```

cachedout added a commit that referenced this pull request Dec 16, 2015

@cachedout cachedout merged commit 98b8cc2 into saltstack:develop Dec 16, 2015

4 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12071 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3135 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11773 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10642 — SUCCESS
Details
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 16, 2015

Contributor

Thanks, @kiorky

Contributor

cachedout commented Dec 16, 2015

Thanks, @kiorky

cachedout added a commit that referenced this pull request Dec 21, 2015

@kiorky kiorky deleted the kiorky:fixgit branch Apr 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment