New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygit2: skip submodules when traversing tree #29772

Merged
merged 1 commit into from Dec 17, 2015

Conversation

Projects
None yet
2 participants
@terminalmage
Member

terminalmage commented Dec 16, 2015

Submodules cannot at this time be traversed by Pygit2 in the same way as
directories. Ignore them when traversing to get the file_list or
dir_list.

Fixes #29631

@terminalmage

This comment has been minimized.

Show comment
Hide comment
@terminalmage

terminalmage Dec 16, 2015

Member

Actually, hold on, I might have misinterpreted the (rather sparse) documentation for the pygit2.Submodule type. I might be able to traverse it after all.

Member

terminalmage commented Dec 16, 2015

Actually, hold on, I might have misinterpreted the (rather sparse) documentation for the pygit2.Submodule type. I might be able to traverse it after all.

@terminalmage

This comment has been minimized.

Show comment
Hide comment
@terminalmage

terminalmage Dec 16, 2015

Member

Yeah, I'm going to close this. I have a better way now which will let us actually support submodules in pygit2 0.22.1 and newer.

Member

terminalmage commented Dec 16, 2015

Yeah, I'm going to close this. I have a better way now which will let us actually support submodules in pygit2 0.22.1 and newer.

@terminalmage

This comment has been minimized.

Show comment
Hide comment
@terminalmage

terminalmage Dec 16, 2015

Member

Actually, I take that back... To use submodules, the submodule directory has to physically be there, which won't happen in gitfs since we don't checkout the refs.

There may be a way to do so, but it's beyond the scope of this pull request and would require some forethought to figure out how to properly implement it.

Reopening.

Member

terminalmage commented Dec 16, 2015

Actually, I take that back... To use submodules, the submodule directory has to physically be there, which won't happen in gitfs since we don't checkout the refs.

There may be a way to do so, but it's beyond the scope of this pull request and would require some forethought to figure out how to properly implement it.

Reopening.

@terminalmage terminalmage reopened this Dec 16, 2015

pygit2: skip submodules when traversing tree
Submodules cannot at this time be traversed by Pygit2 in the same way as
directories. Ignore them when traversing to get the file_list or
dir_list.

Fixes #29631

@terminalmage terminalmage reopened this Dec 17, 2015

cachedout added a commit that referenced this pull request Dec 17, 2015

Merge pull request #29772 from terminalmage/issue29631
pygit2: skip submodules when traversing tree

@cachedout cachedout merged commit 0c65eeb into saltstack:2015.8 Dec 17, 2015

4 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12122 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3186 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11824 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10695 — SUCCESS
Details

@terminalmage terminalmage deleted the terminalmage:issue29631 branch Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment