New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change listen requisite resolution from name to ID declaration #29775

Merged
merged 1 commit into from Dec 16, 2015

Conversation

Projects
None yet
2 participants
@paulnivin
Contributor

paulnivin commented Dec 16, 2015

listen and listen_in resolution should use ID declaration instead of name to look up chunks for state changes. Without this change, triggers can be missed due to checking states of incorrect chunks, where those chunks have names in common but not ID declarations in common. The additional tests should make this issue obvious. At Lyft, we've been missing listen_in triggers due to states changing and then being cleared for the same name.

@thatch45

This comment has been minimized.

Show comment
Hide comment
@thatch45

thatch45 Dec 16, 2015

Member

Thanks @paulnivin ! this is a very subtle issue and I am very grateful that you have found it. The state runtime can be hard debug!

Member

thatch45 commented Dec 16, 2015

Thanks @paulnivin ! this is a very subtle issue and I am very grateful that you have found it. The state runtime can be hard debug!

thatch45 added a commit that referenced this pull request Dec 16, 2015

Merge pull request #29775 from lyft/listen-id-declaration-resolution-…
…stable

Change listen requisite resolution from name to ID declaration

@thatch45 thatch45 merged commit ab61f78 into saltstack:2015.8 Dec 16, 2015

2 of 5 checks passed

jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3162 — FAILURE
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10669 — FAILURE
Details
default Merged build started.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12098 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11800 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment