New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2015.8][Windows] Fix multi-master on windows #29814

merged 3 commits into from Dec 18, 2015


None yet
2 participants

basepi commented Dec 17, 2015

Fixes #29396

This fix gives each minion object in a multi-minion setup unique tcp_pub_port and tcp_pull_port settings, if ipc_mode is tcp. By default, the minion will just use incremental port numbers from the default 4510/4511, as noted in the documentation addition. However, the user can also specify lists of ports to be used.

basepi added some commits Dec 17, 2015

Fix ipc_mode check in windows
Although 'tcp' is the only supported ipc_mode in windows, this
check was completely wrong and would never allow overriding it.

cachedout added a commit that referenced this pull request Dec 18, 2015

Merge pull request #29814 from basepi/
[2015.8][Windows] Fix multi-master on windows

@cachedout cachedout merged commit 7eefaac into saltstack:2015.8 Dec 18, 2015

2 of 5 checks passed

default Merged build finished.
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3208 — FAILURE
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10719 — FAILURE
jenkins/salt-pr-clone Salt PR - Clone Repository #12144 — SUCCESS
jenkins/salt-pr-lint-n Salt PR - Code Lint #11846 — SUCCESS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment