New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to osx packaging scripts #29904

Merged
merged 3 commits into from Dec 22, 2015

Conversation

Projects
None yet
3 participants
@twangboy
Contributor

twangboy commented Dec 21, 2015

Split the build script up into different tasks:

  • build_dev.sh will build a dev environment with everything but salt
  • build_pkg.sh will take the contents of /opt/salt and create a mac osx .pkg installer
  • build_sig.sh will sign a package
  • 'build.shrunsbuild_dev, installs salt, and then runsbuild_pkg`

Broke requirements file into a regular and an extra requirements

  • req.txt : packages that require no additional parameters
  • req_ext.txt : packages that require additional parameters to install correctly (can't be installed with the rest)
  • All versions are downloaded from pypi with specific versions noted in the req files

Changed License, Welcome, and Conclusion to .rtf format
Changed the SaltStack graphic to fit properly in the wizard

My attempts at rebase failed for #29858, ergo this PR

@twangboy twangboy referenced this pull request Dec 21, 2015

Closed

Osx build #29858

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 21, 2015

Contributor

It seems like this is downloading various pieces of software without checking checksums or in many cases, even using HTTPS. Is that correct?

Contributor

cachedout commented Dec 21, 2015

It seems like this is downloading various pieces of software without checking checksums or in many cases, even using HTTPS. Is that correct?

@twangboy

This comment has been minimized.

Show comment
Hide comment
@twangboy

twangboy Dec 21, 2015

Contributor

I'm using the same links that CR used in the original script. I had to use curl instead of wget because that's not installed on a fresh image. We're not checking sha's... yet... that will be added.

Contributor

twangboy commented Dec 21, 2015

I'm using the same links that CR used in the original script. I had to use curl instead of wget because that's not installed on a fresh image. We're not checking sha's... yet... that will be added.

@thatch45

This comment has been minimized.

Show comment
Hide comment
@thatch45

thatch45 Dec 21, 2015

Member

Lets get the sha checks in here before we merge, it should not be a hard add. Just add a sha checking function and call it for each download. Add the shas in the script at the top as variables like
LIBSODIUM_SHA='shashashasha'
And use sha512, since blake is probably not there :P

Member

thatch45 commented Dec 21, 2015

Lets get the sha checks in here before we merge, it should not be a hard add. Just add a sha checking function and call it for each download. Add the shas in the script at the top as variables like
LIBSODIUM_SHA='shashashasha'
And use sha512, since blake is probably not there :P

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 22, 2015

Contributor

I am going to close this until we have the verification requested by @thatch45 added. Please re-open when that's in place and this is ready to go. Thanks.

Contributor

cachedout commented Dec 22, 2015

I am going to close this until we have the verification requested by @thatch45 added. Please re-open when that's in place and this is ready to go. Thanks.

@cachedout cachedout closed this Dec 22, 2015

@twangboy twangboy reopened this Dec 22, 2015

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 22, 2015

Contributor

Great! Looks much better. After the tests run, I'll get this in.

Contributor

cachedout commented Dec 22, 2015

Great! Looks much better. After the tests run, I'll get this in.

@twangboy

This comment has been minimized.

Show comment
Hide comment
@twangboy

twangboy Dec 22, 2015

Contributor

Thanks!

Contributor

twangboy commented Dec 22, 2015

Thanks!

cachedout added a commit that referenced this pull request Dec 22, 2015

Merge pull request #29904 from twangboy/osx_build
Improvements to osx packaging scripts

@cachedout cachedout merged commit 8f8c8ce into saltstack:2015.8 Dec 22, 2015

4 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12299 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3363 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12001 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10881 — SUCCESS
Details

@twangboy twangboy deleted the twangboy:osx_build branch Dec 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment