New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presumably what was meant #29907

Merged
merged 1 commit into from Dec 21, 2015

Conversation

Projects
None yet
2 participants
@bmcorser
Contributor

bmcorser commented Dec 21, 2015

Otherwise it's invalid syntax

Presumably what was meant
Otherwise it's invalid syntax
@cachedout

This comment has been minimized.

Contributor

cachedout commented Dec 21, 2015

Pretty sure that was my typo! Thanks for catching it. :] Much appreciated.

cachedout added a commit that referenced this pull request Dec 21, 2015

Merge pull request #29907 from bmcorser/patch-1
Presumably what was meant

@cachedout cachedout merged commit a938c41 into saltstack:develop Dec 21, 2015

2 of 5 checks passed

default Merged build started.
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3318 — RUNNING
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10833 — RUNNING
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12254 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11956 — SUCCESS
Details

@bmcorser bmcorser deleted the bmcorser:patch-1 branch Dec 21, 2015

@bmcorser

This comment has been minimized.

Contributor

bmcorser commented Dec 21, 2015

@cachedout I actually get *** NameError: name '__jid_event__' is not defined shall I make an issue?

@cachedout

This comment has been minimized.

Contributor

cachedout commented Dec 21, 2015

Yes, please. Drop a reproducible case in there and we'll have a look. Thanks!

@bmcorser

This comment has been minimized.

Contributor

bmcorser commented Dec 21, 2015

Hmmm it was just because I was accessing the name __jid_event__ outside the actual function, I guess before the magic vars get injected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment