New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD pkgng fix for non-interactive install. #29909

Merged
merged 1 commit into from Dec 22, 2015

Conversation

Projects
None yet
2 participants
@abednarik
Contributor

abednarik commented Dec 21, 2015

In pkgng the way to install packages and assuming yes in pre and post install scripts is to use
-y, same as apt-get or yum, for example. Also env variable ASSUME_ALWAYS_YES=YES can be used, but
in this case, is a good idea to follow others package manager implementation.
Also remove the check where only -y is used if pkgng is executed in dryrun mode. In this case
there is no difference between dry run or not.

Fixes #27056

FreeBSD pkgng fix for non-interactive install.
In pkgng the way to install packages and assumming yes in pre and post install scripts is to use
-y, same as apt-get or yum, for example. Also env variable ASSUME_ALWAYS_YES=YES can be used, but
in this case, is a good idea to follow others package manager implementation.
Also remove the check where only -y is used if pkgng is executed in dryrun mode. In this case
there is no difference between dryrun or not.
@abednarik

This comment has been minimized.

Contributor

abednarik commented Dec 21, 2015

References this and this

cachedout added a commit that referenced this pull request Dec 22, 2015

Merge pull request #29909 from abednarik/freebsd_pkgng_non_interactiv…
…e_fix

FreeBSD pkgng fix for non-interactive install.

@cachedout cachedout merged commit ad0de4d into saltstack:2015.5 Dec 22, 2015

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3320 — FAILURE
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10835 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12256 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #11958 — SUCCESS
Details
@cachedout

This comment has been minimized.

Contributor

cachedout commented Dec 22, 2015

Thanks, @abednarik

@abednarik abednarik deleted the abednarik:freebsd_pkgng_non_interactive_fix branch Dec 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment