New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale module: don't escape the slash in \n #30015

Merged
merged 1 commit into from Dec 28, 2015

Conversation

Projects
None yet
2 participants
@anlutro
Contributor

anlutro commented Dec 26, 2015

This would cause the literal string "\n" to be appended to the locale file, after the name of the locale.

I'm not sure what the reason for double-escaping the newline in the first place is. Maybe it works if a locale is replaced, but not if it's appended?

Ref. 44d44ec #25328 #25309

locale module: don't escape the slash in \n
this would cause the literal string "en_US.UTF8\n" to be appended to the
locale file.
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 28, 2015

Contributor

I agree. The original code looks like a typo to me as well.

Contributor

cachedout commented Dec 28, 2015

I agree. The original code looks like a typo to me as well.

cachedout added a commit that referenced this pull request Dec 28, 2015

Merge pull request #30015 from alprs/fix-gen_locale_escaped_newline
locale module: don't escape the slash in \n

@cachedout cachedout merged commit 90611e9 into saltstack:2015.8 Dec 28, 2015

4 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12356 — SUCCESS
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3420 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12058 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #10939 — SUCCESS
Details

@anlutro anlutro deleted the alprs:fix-gen_locale_escaped_newline branch Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment