New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert glusterfs module to use xml #30075

Merged
merged 1 commit into from Jan 4, 2016

Conversation

Projects
None yet
2 participants
@joejulian
Contributor

joejulian commented Dec 29, 2015

The gluster cli has the option to produce xml output from most every
command, and to avoid pausing for questions when being run in script
mode. Make use of that capability and avoid scraping text output that is
often subject to change between versions.

This should help future-proof this module as any changes to the xml
output should be automatically integrated.

As part of this change, I added a glusterfs.info function and added the
force keywords to volume start and volume stop.

Fixes #30051

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Dec 30, 2015

Contributor

Hi @joejulian

This looks great! There are a few small style errors to clean up. Would you mind look at the lint tests and making the recommended changes? After that, we can get this merged. Thanks!

Contributor

cachedout commented Dec 30, 2015

Hi @joejulian

This looks great! There are a few small style errors to clean up. Would you mind look at the lint tests and making the recommended changes? After that, we can get this merged. Thanks!

@joejulian

This comment has been minimized.

Show comment
Hide comment
@joejulian

joejulian Jan 4, 2016

Contributor

Go Go Jenkins!

Contributor

joejulian commented Jan 4, 2016

Go Go Jenkins!

Joe Julian
Convert glusterfs module to use xml
The gluster cli has the option to produce xml output from most every
command, and to avoid pausing for questions when being run in script
mode. Make use of that capability and avoid scraping text output that is
often subject to change between versions.

This should help future-proof this module as any changes to the xml
output should be automatically integrated.

As part of this change, I added a glusterfs.info function and added the
force keywords to volume start and volume stop.

Fixes #30051

cachedout added a commit that referenced this pull request Jan 4, 2016

Merge pull request #30075 from iodatacenters/2015.8_gluster_usexml
Convert glusterfs module to use xml

@cachedout cachedout merged commit 5419699 into saltstack:2015.8 Jan 4, 2016

3 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3853 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12481 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12180 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11066 — SUCCESS
Details
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 4, 2016

Contributor

Great! Merged.

Contributor

cachedout commented Jan 4, 2016

Great! Merged.

@joejulian joejulian deleted the 2015.8_gluster_usexml branch Jan 4, 2016

@joejulian

This comment has been minimized.

Show comment
Hide comment
@joejulian

joejulian Jan 15, 2016

Contributor

Looks good to me.

Contributor

joejulian commented Jan 15, 2016

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment