New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log retryable transport errors as warnings #30128

Merged
merged 1 commit into from Jan 4, 2016

Conversation

Projects
None yet
2 participants
@oeuftete
Contributor

oeuftete commented Jan 3, 2016

This error reached our monitoring system:

Jan 03 05:09:56.719 [ERROR:fileclient.py:1102]: Data transport is broken, got: {'hsum': 'd3b07384d113edec49eaa6238ad5ff00', 'hash_type': 'md5'}, type: <type 'dict'>, exception: 'data', attempt 1 of 3

Given that this failure is going to be immediately retried, logging this at error is inappropriately severe. This PR makes the original error a warning, with an error log message generated when retry attempts are exhausted.

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 4, 2016

Contributor

Good call. Thanks!

Contributor

cachedout commented Jan 4, 2016

Good call. Thanks!

cachedout added a commit that referenced this pull request Jan 4, 2016

Merge pull request #30128 from oeuftete/fileclient-attempt-error-to-w…
…arning

Log retryable transport errors as warnings

@cachedout cachedout merged commit aeec21e into saltstack:2015.8 Jan 4, 2016

3 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3821 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12473 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12172 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11055 — SUCCESS
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment