New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerng.push, and allow for multiple images #30142

Merged
merged 1 commit into from Jan 4, 2016

Conversation

Projects
None yet
2 participants
@terminalmage
Member

terminalmage commented Jan 4, 2016

When I wrote dockerng, I was scraping the API response for the ID of the
image specified in the docker 'push' command. This information is no
longer present in the Docker Remote API response, which makes the
function think that the push failed when it did not.

This commit removes the Id and Image keys from the return
dictionary, as they can no longer reliably be determined from the API
response without it being some sort of hack that will no doubt be broken
the next time Docker decides to change their API.

Not only that, but the status message used to detect a pushed or
already-present layer has also been changed, which necessitated a fix in
_push_status().

This also resolves #29994 by allowing the user to push all tags for a
given repo by omitting the tag.

This also fixes #29993.

Fix dockerng.push, and allow for multiple images
When I wrote dockerng, I was scraping the API response for the ID of the
image specified in the docker 'push' command. This information is no
longer present in the Docker Remote API response, which makes the
function think that the push failed when it did not.

This commit removes the ``Id`` and ``Image`` keys from the return
dictionary, as they can no longer reliably be determined from the API
response without it being some sort of hack that will no doubt be broken
the next time Docker decides to change their API.

Not only that, but the status message used to detect a pushed or
already-present layer has also been changed, which necessitated a fix in
``_push_status()``.

This also resolves #29994 by allowing the user to push all tags for a
given repo by omitting the tag.

cachedout added a commit that referenced this pull request Jan 4, 2016

Merge pull request #30142 from terminalmage/issue29994
Fix dockerng.push, and allow for multiple images

@cachedout cachedout merged commit 1a21b3d into saltstack:2015.8 Jan 4, 2016

3 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-linode-ubuntu14.04-n Salt PR - Linode Ubuntu 14.04 #3877 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12487 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12186 — SUCCESS
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11073 — SUCCESS
Details

@terminalmage terminalmage deleted the terminalmage:issue29994 branch Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment