New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the periodic call to beacons #30202

Merged
merged 1 commit into from Jan 12, 2016

Conversation

Projects
None yet
2 participants
@opdude
Contributor

opdude commented Jan 7, 2016

This solves the bug where all beacons are no longer being checked for changes

Fixed the periodic call to beacons
This solves the bug where all beacons are no longer being checked for changes
@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 12, 2016

Contributor

@opdude I'm a little confused here. Why should we run beacons if none were found during their processing? Could you explain what's happening here in a little more detail, please? Thanks.

Contributor

cachedout commented Jan 12, 2016

@opdude I'm a little confused here. Why should we run beacons if none were found during their processing? Could you explain what's happening here in a little more detail, please? Thanks.

@opdude

This comment has been minimized.

Show comment
Hide comment
@opdude

opdude Jan 12, 2016

Contributor

I was also confused by this code. But this line I moved out of this function because it should be the original caller to the function itself. Without this beacons will never run.

Contributor

opdude commented Jan 12, 2016

I was also confused by this code. But this line I moved out of this function because it should be the original caller to the function itself. Without this beacons will never run.

@cachedout

This comment has been minimized.

Show comment
Hide comment
@cachedout

cachedout Jan 12, 2016

Contributor

You're totally right. I think this was a mistake. Thanks for catching it!

Contributor

cachedout commented Jan 12, 2016

You're totally right. I think this was a mistake. Thanks for catching it!

cachedout added a commit that referenced this pull request Jan 12, 2016

@cachedout cachedout merged commit 903289d into saltstack:2015.8 Jan 12, 2016

2 of 5 checks passed

default Merged build finished.
Details
jenkins/salt-pr-rs-cent7-n Salt PR - RS CentOS 7 #11128 — FAILURE
Details
jenkins/salt-pr-rs-ubuntu14.04-n Salt PR - RS Ubuntu 14 #8622 — FAILURE
Details
jenkins/salt-pr-clone Salt PR - Clone Repository #12541 — SUCCESS
Details
jenkins/salt-pr-lint-n Salt PR - Code Lint #12240 — SUCCESS
Details
@opdude

This comment has been minimized.

Show comment
Hide comment
@opdude

opdude Jan 12, 2016

Contributor

No problem :)

Contributor

opdude commented Jan 12, 2016

No problem :)

@opdude opdude deleted the Unity-Technologies:hotfix/beacon_periodic branch Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment